Imported project into Android Studio#1
Open
aseggemu-fyber wants to merge 2 commits intoHeyzap:masterfrom
aseggemu-fyber:RDT-109-update-the-android-example-app
Open
Imported project into Android Studio#1aseggemu-fyber wants to merge 2 commits intoHeyzap:masterfrom aseggemu-fyber:RDT-109-update-the-android-example-app
aseggemu-fyber wants to merge 2 commits intoHeyzap:masterfrom
aseggemu-fyber:RDT-109-update-the-android-example-app
Conversation
aseggemu-fyber
commented
Nov 30, 2018
aseggemu-fyber
commented
- The project imported into Android Studio.
- Replaced app icon launcher.
- Replaced the layout colour with new Fyber logo colour.
- Updated
- .gitignore file
- project file structure
- The project imported into Android Studio. - Replaced app icon launcher. - Replaced the layout colour to new Fyber logo colour. - Updated .gitignore file
joaocunhajeronimo
requested changes
Nov 30, 2018
joaocunhajeronimo
left a comment
joaocunhajeronimo
left a comment
There was a problem hiding this comment.
The overall migration for Android Studio seems fine. However, this app seems a bit buggy... For starters there are some UI interactions directly from the Heyzap callbacks (witout a sync to the UI thread) lading to crashes.
Not sure if we should run some sort of smoke testing before linking it on the portal. Then again, curretnly we have an Eclipse app with the same bugs...
.gitignore
Outdated
| *.ipr | ||
| *.iws | ||
| .idea/ | ||
| .idea/workspace.xml |
There was a problem hiding this comment.
Can you replace this and the lines below with
.idea/
?
Author
There was a problem hiding this comment.
I updated the .gitignore with the replace.
Please review commit
1a3875e
replaced with .idea/
joaocunhajeronimo
approved these changes
Nov 30, 2018
Author
|
@joaocunhajeronimo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.